Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cocoa] Refactor caps lock indicator display logic #12431

Merged
merged 1 commit into from
Apr 5, 2023
Merged

[Cocoa] Refactor caps lock indicator display logic #12431

merged 1 commit into from
Apr 5, 2023

Conversation

pxlcoder
Copy link
Member

@pxlcoder pxlcoder commented Apr 5, 2023 •
edited by webkit-early-warning-system
Loading

d263ebe

[Cocoa] Refactor caps lock indicator display logic
https://bugs.webkit.org/show_bug.cgi?id=255056
rdar://107582325

Reviewed by Wenson Hsieh.

* Source/WebCore/rendering/RenderThemeCocoa.mm:
(WebCore::canShowCapsLockIndicator):
(WebCore::RenderThemeCocoa::shouldHaveCapsLockIndicator const):

Canonical link: https://commits.webkit.org/262645@main

82d760f

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk1   🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-wk2   🧪 api-gtk
✅ 🛠 tv-sim   🧪 mac-AS-debug-wk2
  🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim
✅ 🛠 🧪 unsafe-merge

@pxlcoder pxlcoder self-assigned this Apr 5, 2023
@pxlcoder pxlcoder added the Forms For bugs specific to form elements (checkboxes, buttons, text fields, etc.) label Apr 5, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Apr 5, 2023 •
edited
Loading

EWS run on current version of this PR (hash 82d760f)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk1   🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-wk2   🧪 api-gtk
✅ 🛠 tv-sim   🧪 mac-AS-debug-wk2
  🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim
✅ 🛠 🧪 unsafe-merge

@pxlcoder pxlcoder added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 5, 2023
@pxlcoder
[Cocoa] Refactor caps lock indicator display logic
d263ebe 
https://bugs.webkit.org/show_bug.cgi?id=255056
rdar://107582325

Reviewed by Wenson Hsieh.

* Source/WebCore/rendering/RenderThemeCocoa.mm:
(WebCore::canShowCapsLockIndicator):
(WebCore::RenderThemeCocoa::shouldHaveCapsLockIndicator const):

Canonical link: https://commits.webkit.org/262645@main
@webkit-commit-queue
Copy link
Collaborator

Committed 262645@main (d263ebe): https://commits.webkit.org/262645@main

Reviewed commits have been landed. Closing PR #12431 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit d263ebe into WebKit:main Apr 5, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whsieh whsieh whsieh approved these changes

Assignees

@pxlcoder pxlcoder

Labels
Forms For bugs specific to form elements (checkboxes, buttons, text fields, etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pxlcoder @webkit-early-warning-system @webkit-commit-queue @whsieh